feat: add status property support for series markers #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Actually found this change is not accessible. Will work on updating that |
jperals
reviewed
Nov 12, 2025
jperals
reviewed
Nov 12, 2025
Add support for displaying series markers with different status states, particularly a "warning" status. This enables visual indication of series that require attention or have issues. Changes include: - Extend Highcharts SeriesOptions interface with optional status property - Update ChartSeriesMarker to accept and render status prop - Pass status through chart legend and tooltip components - Add visual examples in marker-permutations page for warning state
Pixselve
force-pushed
the
warning-icon-to-markers
branch
from
d57ee33 to
fab6169
Compare
Contributor
Author
|
Updated the warning icon to make it overlap a little with the marker: 
|
pan-kot
reviewed
Nov 26, 2025
pan-kot
reviewed
Nov 26, 2025
pages/03-core/core-legend.page.tsx
Outdated
| import pseudoRandom from "../utils/pseudo-random"; | ||
|
|
||
| const i18nStrings = { | ||
| seriesStatusWarningAriaLabel: "warning", |
Member
There was a problem hiding this comment.
you can create us a feature request to add support for this prop in the built-in i18n
pan-kot
reviewed
Nov 26, 2025
pan-kot
reviewed
Nov 26, 2025
Member
|
The doubling of the marker sizes affected the spacing of the legend and tooltip items by a lot. I don't think we should do this: we can try to make the size increase smaller, and can also update the spacings of the legend and the tooltip. 
|
pan-kot
reviewed
Dec 5, 2025
Member
|
Note that the PR has some conflicts to be solved. |
…icon-to-markers # Conflicts: # src/__tests__/__snapshots__/documenter.test.ts.snap # src/core/chart-api/chart-extra-legend.tsx # src/core/interfaces.ts # src/core/utils.ts
# Conflicts: # src/core/chart-api/chart-extra-legend.tsx # src/core/components/core-tooltip.tsx
Contributor
Author
Resolved the conflict |
pan-kot
reviewed
Dec 18, 2025
pan-kot
reviewed
Dec 18, 2025
…icon-to-markers # Conflicts: # src/core/utils.ts
pan-kot
reviewed
Jan 6, 2026
pan-kot
reviewed
Jan 7, 2026
pan-kot
approved these changes
Jan 7, 2026
Merged
via the queue into
cloudscape-design:main
with commit Jan 7, 2026
73cbd49
42 of 44 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for displaying series markers with different status states, particularly a "warning" status. This enables visual indication of series that require attention or have issues.
Changes include:
How has this been tested?
Review checklist
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.